Re: Issues with exceptions and overloading opcodes

On Wed, 21 Oct 2015, Dmitry Stogov wrote: > > On Oct 20, 2015 6:11 PM, "Xinchen Hui" <laruence@php.net> wrote: > > > On Tue, Oct 20, 2015 at 10:45 PM, Derick Rethans <derick@php.net> wrote: > > > >> When hacking on Xdebug for PHP 7, I ran into some issues where PHP > >> would just spin around. This happens when there is an exception, > >> and I use overloaded opcodes. I wrote a small example extension at > >> > >> https://github.com/derickr/php-minimal-opcode-overloading-example > >> with a test case ( > >> > >> https://github.com/derickr/php-minimal-opcode-overloading-example/blob/master/tests/test.php > >> > >> ) that shows that something is looping in executing opcodes, as the > >> HANDLE_EXCEPTION iirc doesn't advance to the next opline. I believe > >> this is a recent enough change, as it only started happening after > >> I upgraded from about RC1 to latest master. > >> > >> Would you care to have a look? > >> > > This is introduced by a fix made by Bob, > > https://github.com/php/php-src/commit/808f62bb > > > > Bob, I am going to revert this for now, since you didn't include a > > test script to show where the problem was, I am not sure why you > > made this? > > I think, we discussed that patch with Bob, and it looked right. May be > we missed some edge case... > > It's not possible to write a test case for it. I just did ;-) It requires loading this extension though! In any case, it is causing a bug, and one that ought to be adressed before the next RC. cheers, Derick