Re: Small regression in PHP-LDAP

Hi Côme, Côme Chilliet wrote:

The use of ldap_connect(host:port) without ldap:// is not something that is in the tests, and is not explicitely allowed by our documentation: http://php.net/manual/en/function.ldap-connect.php

I don't use LDAP, so maybe it's different here, but accepting both 'scheme://host:post' and 'host:port' is normal for places where URIs are accepted and the scheme can be inferred. It might not have been documented, but it makes sense to me that people thought it would work.

So basically my question is, is that something that should be "fixed" to be consistent with previous PHP version, or should it stay that way as this is what is documented and tested?

I'd argue this is a regression, documented feature or not. Supporting 'host:port' is not a bug, and this has broken existing code, which micro (x.y.Z) versions are not allowed to do. It should be fixed ASAP. Thanks. -- Andrea Faulds http://ajf.me/