Re: Null bytes in anonymous class names
| From: | Adam Harvey | Date: | Mon, 09 Nov 2015 23:51:47 +0000 |
| Subject: | Re: Null bytes in anonymous class names | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-89133@lists.php.net to get a copy of this message | ||
On 9 November 2015 at 13:46, Derick Rethans <derick@php.net> wrote:
> On Thu, 5 Nov 2015, Niklas Keller wrote:
>
>> I discovered today that anonymous class names contain a null byte
>> right after "class@anonymous". I don't think class names should
>> contain non-printable characters.
>>
>> How about removing that null byte?
>
> I would suggest replacing it with something else. As I am making this
> work for Xdebug, I really need to ship the full name to the IDE so that
> they can later do look-ups on anonymous class properties, and with the
> \0 the IDEs seem to fuck this up. I suggest using another @ instead of
> the \0.
Just to add another voice: +1 for this (or something similar). Having
the \0 can be worked around, but just not having to deal with it at
all is a hell of a lot easier for those of us working on third party
tooling.
Adam