Re: HashDos protection
| From: | Remi Collet | Date: | Fri, 27 Nov 2015 07:16:47 +0000 |
| Subject: | Re: HashDos protection | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-89459@lists.php.net to get a copy of this message | ||
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Le 26/11/2015 18:24, Nikita Popov a écrit :
> Here is an implementation of this mechanism for PHP:
> https://github.com/php/php-src/pull/1565
>
> This is the approach I would recommend for PHP. The patch for this
> change is small and non-intrusive and does not break ABI. From my
> testing it has no adverse performance impact. (In microbenchmarks
> I found it to even be consistently faster, as it uses a more
> specialized implementation for a commonly used type of insertion
> operation.)
Thanks for this work.
I agree, this seems a very acceptable solution, I would also recommend
it, even for 7.0.1 (perhaps even for 5.6 if possible)
Remi.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlZYA18ACgkQYUppBSnxahg7pQCeNCpRjQxdzZz9MXF94snPsigB
nxwAn0lK0VAZgn5u4n+S1C1ABlvRrRWU
=otYB
-----END PGP SIGNATURE-----