Re: Push Litespeed SAPI 6.9 to PHP 7.0.1

For some reason Litespeed 6.9 is committed to the 7.0 branch as Litespeed 6.9, but the bugfix is not included? https://github.com/php/php-src/blob/PHP-7.0/sapi/litespeed/lsapi_main.c#L604 The bugfix is only found in master. -- Tom Sommer On 2015-12-16 14:52, Lior Kaplan wrote:

George, Can you take a look at Tom's comment about this problem. Thanks, Kaplan On Wed, Dec 16, 2015 at 3:51 PM, Lior Kaplan <lior.k@zend.com> wrote:

Hi Tom, The patch isn't even committed to the 7.0 branch, only exists on master. And also 7.0.1 is already tagged a few hours ago. So, do the change on 7.0 branch and it will be part of 7.0.2. Kaplan On Wed, Dec 16, 2015 at 3:41 PM, Tom Sommer <mail@tomsommer.dk> wrote:

Hi I realise 7.0.1 is already out in RC1, but there is a bug in the Litespeed 6.8 sapi which breaks php_flag and php_value. It's causing our customers a lot of headaches. I see Litespeed 6.9 is already in master, but would it be possible to get backported into 7.0.1? The fix is here: https://github.com/php/php-src/commit/5bcb7a7019a49c2f80eda7d2aa947efebeee0034#diff-e8087496f5a642ce83e5d655c08c6b3a (I believe) Thanks -- Tom Sommer -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php