Re: ext/interbase maintanance

From: Date: Tue, 22 Dec 2015 10:23:06 +0000
Subject: Re: ext/interbase maintanance
References: 1 2  Groups: php.internals 
Request: Send a blank email to internals+get-89867@lists.php.net to get a copy of this message
On 22/12/15 08:43, Xinchen Hui wrote: >> Here is a working patch of mine: > https://gist.github.com/laruence/f3af903012902818d7da > > if you are going to work on this, please base on this one. > > since I still don't have setup a evn to test it... so there might be some > problems > > thanks Xinchen ... working test setup should be easy, but I'm more than happy to run tests, my problem is the core code has changed so drastically since I ACTUALLY did bug fixes at that level that I don't understand the current methods :( I can understand this new patch but I still need to back-pedal the old one. The only bit I'm not quite following is the switching between 'NULL' and '0' as I'm not sure why you are switching to '0' for some handles that are currently 'NULL' and then defaulting others which were '0' to 'NULL' but I think it's that we are now passing a pointer rather than a handle? I need to re-sync my repository with git.php.net then at least I can track and roll back changes ... I'll get back to this later -- Lester Caine - G8HFL ----------------------------- Contact - http://lsces.co.uk/wiki/?page=contact L.S.Caine Electronic Services - http://lsces.co.uk EnquirySolve - http://enquirysolve.com/ Model Engineers Digital Workshop - http://medw.co.uk Rainbow Digital Media - http://rainbowdigitalmedia.co.uk

« previous php.internals (#89867) next »