Re: Removing weird error message
| From: | Dmitry Stogov | Date: | Tue, 22 Dec 2015 16:54:45 +0000 |
| Subject: | Re: Removing weird error message | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-89871@lists.php.net to get a copy of this message | ||
It looks like the problem is a bit more complex.
The messed test Zend/tests/bug70083.phpt shows it.
My patch removes the error message, and it starts to work without errors
and warnings (I suppose we should have a warning)
Please ignore the patch before we found a consistent solution.
Thanks. Dmitry.
On Tue, Dec 22, 2015 at 7:16 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> Hi,
>
> Please take a look into the patch (for master)
>
> https://gist.github.com/dstogov/44a3f2df71de31986d4c
>
> It removes weird error message and replaces it with silent handling after
> warning message. This makes engine behavior more consistent. Engine uses
> this "silent handling after warning" for many other different errors. e.g.
> - Attempt to modify property of non-object
> - Illegal offset type
> - Cannot add element to the array as the next element is already occupied
> - Cannot use a scalar value as an array
> - This object doesn't support property references
>
> This error message was introduced by Bob by
> f57cb13c566613eec0e1c2f6d96d18565436a9b7 commit.
>
> Do anybody object against removing this error message in master?
>
> Should it be removed in PHP-5.6 and PHP-7.0 as well?
>
> Thanks. Dmitry.
>