Re: Fixing bug #71038 session_start() returns TRUE on failure
| From: | Stanislav Malyshev | Date: | Fri, 15 Jan 2016 07:05:59 +0000 |
| Subject: | Re: Fixing bug #71038 session_start() returns TRUE on failure | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-90654@lists.php.net to get a copy of this message | ||
Hi!
> I made PR
> https://github.com/php/php-src/pull/1721
>
> for bug #71038
> https://bugs.php.net/bug.php?id=71038
>
> Currently, the patch is written as it should and
> breaks compatibility on PHP 5.6.
>
> To be compatible with PHP 5.6 (PHP 7.0 is OK),
> it may ignore read failures returned from save handlers.
I think it should return false on 5.6 too. The docs say:
This function returns TRUE if a session was successfully started,
otherwise FALSE.
Thus, if the session was *not* successfully started, it should return
false.
--
Stas Malyshev
smalyshev@gmail.com