Re: WIKI: phpng-upgrading

Hi Sean, On Thu, Jan 21, 2016 at 7:07 AM, Sean DuBois <sean@siobud.com> wrote: > > I tried to get access to that page as well, but didn't have any luck > would you mind adding the zend_parse_paramaters changes? > > 'l' went from 'long' -> 'zend_long' and 's' went > from 'int' -> 'size_t'. > > So many extensions have been ported without this in mind, and it bites > in really nasty hard to reproduce runtime ways. Good point. zend_parse_parameters() is using "size_t" for string length, since zend_string uses size_t for it. struct _zend_string { zend_refcounted_h gc; zend_ulong h; /* hash value */ size_t len; char val[1]; }; AFAIK, PHP7 repo's function parameters are changed to size_t. This should be described in upgrading doc for 3rd party module developers. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net