Re: PR1739
| From: | Yasuo Ohgaki | Date: | Thu, 28 Jan 2016 04:33:02 +0000 |
| Subject: | Re: PR1739 | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-90987@lists.php.net to get a copy of this message | ||
Hi Anatol,
On Thu, Jan 28, 2016 at 12:48 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>
> https://github.com/php/php-src/pull/1739
> This PR is good one. It opens handler first, then proceeds.
> It fixes save handler crash also.
>
> The PR does not break our tests and PHP7 only fix. However, It changes
> handler execution order. This change will not affect normal
> operation/code at all, but user's unit tests may detect the difference
> as we had already.
>
> Would you like to include this PR in released version?
> My opinion is +1 for applying this.
It's committed to master
46d4a371054f43fe8aeca14b83ba722adc84ac10
If you decide merge it, please cherry pick.
Thank you.
--
Yasuo Ohgaki
yohgaki@ohgaki.net