RE: [PHP-DEV] Re: [RFC] Warn about invalid strings in arithmetic (moving back todiscussion)
| From: | Zeev Suraski | Date: | Thu, 28 Jan 2016 09:25:37 +0000 |
| Subject: | RE: [PHP-DEV] Re: [RFC] Warn about invalid strings in arithmetic (moving back todiscussion) | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-90989@lists.php.net to get a copy of this message | ||
> -----Original Message-----
> From: Andrea Faulds [mailto:ajf@ajf.me]
> Sent: Tuesday, January 26, 2016 11:36 PM
> To: internals@lists.php.net
> Subject: [PHP-DEV] Re: [RFC] Warn about invalid strings in arithmetic (moving
> back todiscussion)
>
> ...I proof-read my email, but I forgot the most important thing. The link!
>
> https://wiki.php.net/rfc/invalid_strings_in_arithmetic
>
> Sorry.
>
> Andrea Faulds wrote:
> > Good evening,
> >
> > I had opened the vote for this RFC, but then I was reminded by a
> > discussion in the pull request about a particular unresolved problem I
> > had forgotten about.
> >
> > In order to deal with that issue, I have cancelled the vote and
> > expanded the RFC (both in length and scope) to deal with it.
> >
> > The specific issue is detailed in a new section, "Fractional and
> > scientific notation strings with integer operators", but it affects
> > other sections as well.
> >
> > So, the RFC is back under discussion.
> >
> > Please read it and tell me your thoughts.
Andrea,
I think this is a good proposal. Slightly worried about the E_NOTICE for things like
"5px" + "10px", which I think are probably not uncommon, and would have been
better served by a separate E_STRICT, but that's no longer (practically) available.
Either way seems like a good idea.
Thanks,
Zeev