Re: pdo_dblib pull requests
| From: | Lior Kaplan | Date: | Sat, 06 Feb 2016 22:09:21 +0000 |
| Subject: | Re: pdo_dblib pull requests | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-91103@lists.php.net to get a copy of this message | ||
Hi Adam,
First, thanks for contributing.
I think the best way would be to try and provide tests (part of the PR) and test environment for
this change.
If the latter can't be provided, maybe instructions how to create one (as you guys probably
have far more experience then us).
Kaplan
________________________________________
From: Adam Baratz <adam.baratz@gmail.com>
Sent: Friday, February 5, 2016 8:04 PM
To: internals@lists.php.net
Subject: [PHP-DEV] pdo_dblib pull requests
Hi,
I work for the rare company that uses Linux PHP servers with MSSQL. We rely
quite a bit on this extension and have invested a little in some feature
improvements. I'd like to get them pushed upstream, but given the
relatively low usage of this extension, it seems like PRs easily get stuck
in limbo because of the difficulty in testing/verifying them (e.g.,
https://github.com/php/php-src/pull/1122).
What process would people
recommend for sharing our work?
Thanks,
Adam