Re: [RFC] Generalize support of negative string offsets
| From: | François Laupretre | Date: | Thu, 11 Feb 2016 14:19:59 +0000 |
| Subject: | Re: [RFC] Generalize support of negative string offsets | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-91207@lists.php.net to get a copy of this message | ||
String offsets are full of oddities :
$str = "abc";
$str{0} = '';
var_dump($str); // -> string(3) "bc" (read as "\0bc")
Assigning an empty string to a string offset inserts a null byte because the string length is not checked in zend_assign_to_string_offset().
I see this as a bug. IMO, this case should raise a warning and the string should remain unchanged.
Thoughts before I register a bug and a PR ?
Regards
François