RE: php-ldap pull request

> -----Original Message----- > From: Anatol Belski [mailto:anatol.php@belski.net] > Sent: Thursday, February 18, 2016 7:00 PM > To: 'Côme Chilliet' <come@opensides.be> > Subject: RE: php-ldap pull request > > Hi Côme, > > > -----Original Message----- > > From: Côme Chilliet [mailto:come@opensides.be] > > Sent: Wednesday, February 17, 2016 4:13 AM > > To: ab@php.net > > Subject: php-ldap pull request > > > > Hello, > > > > There was a pull request concerning PHP-LDAP: > > https://github.com/php/php- > > src/pull/1765 > > Seeing how you were active on the bug tracker on the bug about windows > > ldap config file, I thought you might have an opinion about this PR: Should I > merge it? > > It seems weird to me to be able to ignore the config file TLS option > > by using ldap_set_option after and I don’t see what the use case would > > be, but it seems these are standard openldap options so I don’t see > > either on what base I could refuse this change. > > > > Also, someone suggested to just add a way to set any option: > > https://bugs.php.net/bug.php?id=70131 > > Do you think that would be a good idea? > > It’s true a lot of LDAP options are currently missing in the PHP > > extension. (for > > instance: https://bugs.php.net/bug.php?id=50924) > > > Thanks for asking. IMHO it is fine to add new config options, especially that they > available in OpenLDAP itself. > > Though I wouldn't recommend to add "anything" possible just because one can. > Any option has different impact and would require some different > implementation, value type, etc. IMHO it is better to go for an implementation if > there is some use case demanding it. > > With the PR #1765 you mention - it doesn't seem to introduce any BC issues > (please correct if I'm wrong). So if you think it makes sense, I'd not object > applying even to 7.0, to master in any case. > Linking internals@ in. Regards Anatol