Re: unpack()
| From: | Dmitry Stogov | Date: | Thu, 25 Feb 2016 11:07:05 +0000 |
| Subject: | Re: unpack() | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-91395@lists.php.net to get a copy of this message | ||
You are right about the error. Thanks for checking.
________________________________
From: Michael Wallner <mike.php.net@gmail.com> on behalf of Michael Wallner
<mike@php.net>
Sent: Thursday, February 25, 2016 13:53
To: Dmitry Stogov
Cc: internals@lists.php.net; Hynek Bartoš
Subject: Re: [PHP-DEV] unpack()
I think the requested feature may be really useful.
And the implementation is really simple https://gist.github.com/dstogov/edbb1efcd1e9701e75ab
There seems to be a typo at https://gist.github.com/dstogov/edbb1efcd1e9701e75ab#file-unpack-diff-L23
where ‘&&’ should be ‘||’ in the ‘if’ condition.
I think, committing this into master doesn't require RFC and voting.
Anyone objects?
+1
Regards,
Mike