Re: [RFC][VOTE] Precise session management

Hi Derick, On Wed, Mar 9, 2016 at 8:48 PM, Derick Rethans <derick@php.net> wrote: >> Hi all, >> >> This mail is for RFC vote notice. >> >> The RFC is >> https://wiki.php.net/rfc/precise_session_management >> The PR is >> https://github.com/php/php-src/pull/1734 >> >> I suppose almost all questions and discussion is finished, but >> if you have any, please comment/ask. >> >> Vote starts 2016-03-09-09:00(UTC) and ends 2016-03-23-09:00(UTC) >> https://wiki.php.net/rfc/precise_session_management#vote >> >> Please note that I set 2/3 of supporters is required to pass even if it >> is not strictly required. Please let us know the reason why if one >> would like to vote against this RFC. Thank you. > > Voted for, but I have added some comments to the PR. Thank you for comments. Session module returns FALSE for invalid status, therefore it would be better to return FALSE. IMO. However, this patch is for 7.1, so it can be changed. If we are going to change this, it would be nicer to change them all. I left some old changes in php.ini-*, these should be fixed. Thank you. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net