Re: Exceptions and a real example: Tidy

On Fri, 2004-04-16 at 03:32, Derick Rethans wrote: > Do you mean E_ERRORS become exceptions or also E_WARNINGS? E_WARNINGS > should never become exceptions as it's a non-fatal error. E_WARNINGs are exceptions. If you look at the code with the patch applied, I've downgraded all truly minor error conditions to E_NOTICE and made E_WARNINGs errors which are actually problems (i.e. I couldn't find this file), but recoverable. Alan pointed out that it'd be nice if exceptions didn't necessary stop the script if it wasn't caught -- but considering that isn't available at this time this is the best solution. In 5.1, if we have exceptions which are not terminating if uncaught, I'll upgrade a few of the thrown exceptions in Tidy to them. I'll commit my changes later today with the suggestions made by Ilia and others barring any strong arguments against the solution. John -- -=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=- John Coggeshall http://www.coggeshall.org/ The PHP Developer's Handbook http://www.php-handbook.com/ -=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=-