Re: Re: [RFC] [Discussion] Octal overflow detection

Den 2016-04-19 kl. 01:24, skrev Sara Golemon:

On Tue, Apr 12, 2016 at 7:38 PM, Sara Golemon <pollita@php.net> wrote:

https://wiki.php.net/rfc/octal.overload-checking Because having this expression evaluate to true makes me sad: ("\000" === "\400")

I haven't heard any responses on this and wanted to bump it back to the top of your newsreaders. For the record, my inclination is to raise a warning on octal overflow, but not change behavior (at least, not for 7.1, perhaps later). Note that this warning would bubble up during the lexing phase, so an opcache would prevent it from raising on every page load. That's probably fine, the alternative is to signal the parser to bake it into the ast output and that's way over-engineered. -Sara This reminds me a bit about the RFC: https://wiki.php.net/rfc/invalid_strings_in_arithmetic.

So an E_WARNING it should be and option 2. In my opinion no deprecation is needed. Cheers //Björn