Re: "finally" handling refactoring (Bug #72213)
| From: | Derick Rethans | Date: | Fri, 20 May 2016 12:47:45 +0000 |
| Subject: | Re: "finally" handling refactoring (Bug #72213) | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-93414@lists.php.net to get a copy of this message | ||
On Fri, 20 May 2016, Dmitry Stogov wrote:
> Please review the path
>
> https://gist.github.com/dstogov/0a809891c6a3ac3fac4bd0d9711dd330
https://gist.github.com/dstogov/0a809891c6a3ac3fac4bd0d9711dd330#file-bug72213-diff-L194-L196
https://gist.github.com/dstogov/0a809891c6a3ac3fac4bd0d9711dd330#file-bug72213-diff-L356-L358
Why are you switching these around?
https://gist.github.com/dstogov/0a809891c6a3ac3fac4bd0d9711dd330#file-bug72213-diff-L500-L501
https://gist.github.com/dstogov/0a809891c6a3ac3fac4bd0d9711dd330#file-bug72213-diff-L511-L512
You should probably remove them instead of commenting them out.
And Nikita, does this fix my issues with trying to walk through the
possible paths and branches with Xdebug?
>
> I hope, it should completely fix =‘øåU#…þ
> ÓN‡žèhttps://bugs.php.net/bug.php?id=72213
>
>
> I'm going to commit this on Monday.
To which branches?
cheers,
Derick