Re: Allow empty property names
| From: | Jakub Zelenka | Date: | Sun, 29 May 2016 19:23:18 +0000 |
| Subject: | Re: Allow empty property names | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-93628@lists.php.net to get a copy of this message | ||
On Tue, May 24, 2016 at 5:37 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:
> On Sun, May 8, 2016 at 5:04 PM, Jakub Zelenka <bukka@php.net> wrote:
>
>> Hi,
>>
>> I have been thinking about it and I would be ok with removing _empty_ in
>> 7.1. That inconsistency is quite annoying and I never liked it. If we can
>> rid of it, that would be great! I realise the BC concern but I see that
>> more as a limitation and inconsistency between array and object decoding.
>> It's more an edge case anyway so I don't think there should be a big
>> concern. I think that it makes sense to hear if anyone would be against it
>> in json but I think that the limitation could go away already as it has
>> been discussed more than a month ago and I don't see any real objections.
>>
>> @Nikita: if you merge it, I will be happy to create a PR for json...
>>
>> Cheers
>>
>> Jakub
>>
>
> Sorry for the delay, I've merged the patch now:
>
> https://github.com/php/php-src/commit/674297c7e41013c2c34d770051714518d0586271
>
> Nikita
>
Thanks. I have just created a PR for json:
https://github.com/php/php-src/pull/1926
I will wait a week or two and if there are no objections, I will merge it
to master.
Cheers
Jakub