Re: [RFC] Throw Exception on Attempt of ConstantRedefinition
| From: | Christoph Becker | Date: | Mon, 13 Jun 2016 11:37:01 +0000 |
| Subject: | Re: [RFC] Throw Exception on Attempt of ConstantRedefinition | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-93931@lists.php.net to get a copy of this message | ||
On 11.06.2016 at 17:01, Fleshgrinder wrote:
> On 6/10/2016 10:06 PM, Dmitry Stogov wrote:
>>
>> Please review:
>> https://wiki.php.net/rfc/constant_redefinition
>
> This would be a breaking change in a minor release again.
>
> -1
>
> However +1 for PHP 8.
I'm also somewhat concerned with regard to turning a notice into an
exception in a minor version. I would prefer to have an alternative
voting option to deprecate constant redefinition in 7.1 and to finally
disallow it in 8.0.
It might be helpful to make a rough plan when PHP 8.0 will be released.
If that will be far in the future (say 5 years or even more), such a
change might be okay for a minor version (presumably nobody wants to
wait such a long time for this and similar improvements), but if PHP 8.0
will be released much earlier, it might be tolerable to wait and to not
break semantic versioning.
--
Christoph M. Becker