Re: Improve GD test suite

On 17.06.2016 at 15:54, Pierre Joye wrote: > The current testing code is under new bsd, so there is no license issue > here. Fine! > I plan to improve the current code to be more useful as well as adding > perceptual diff. My initial idea was to use pdiff. It is under gpl but as > it uses only for the tests suite it is ok. Sadly not for php. Alternatively > the cmd pdiff can be used but it is then slower. That sounds great. :) To clarify: you're talking about <http://pdiff.sourceforge.net/>, don't you? > In any case we can expose the image diff functions in ext/gd but it will > need some work on the results to be useful in the wild. For now, I have submitted PR #1949 (<https://github.com/php/php-src/pull/1949>), because I see the need to get away from the md5() based image verification ASAP, see <https://github.com/php/php-src/pull/1949#issuecomment-226997805>. > It should also be easy to write a script to port test from c to/from php > to complete both side testing. That would be fantastic! -- Christoph M. Becker