Re: [RFC][Vote] Throw Error in Extensions

Hi! >> Voting has opened on the RFC to change most conditions in extensions that raise E_ERROR or >> E_RECOVERABLE_ERROR to throw an instance of Error instead. >> >> RFC: https://wiki.php.net/rfc/throw_error_in_extensions >> <https://wiki.php.net/rfc/throw_error_in_extensions> >> PR: https://github.com/php/php-src/pull/1942 >> <https://github.com/php/php-src/pull/1942> Isn't there a case that php_error(E_ERROR) does not return? At least it was in 5.x, I'm not sure if that didn't change. If so, we need to be very careful here - some code may make assumptions about the things because of previous E_ERROR conditions, and if zend_throw_error returns where php_error didn't there might be subtle and dangerous bugs. -- Stas Malyshev smalyshev@gmail.com