Re: [RFC] [Vote] var_info
| From: | Stanislav Malyshev | Date: | Fri, 08 Jul 2016 22:19:58 +0000 |
| Subject: | Re: [RFC] [Vote] var_info | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-94437@lists.php.net to get a copy of this message | ||
Hi!
> Lastly, I'll just leave this list of type-related improvements I'd actually
> like to see:
> * Make is_object() return true for IncompleteClass. This is just
> ridiculous. I care zero about the theoretical BC impact.
I have no idea why it doesn't do so. I'll try to dig up when it was made
so and see if there's some explanation.
> * Make gettype() return 'resource (unknown type)' instead of just
> 'unknown type' for closed resources. This makes the output clear while
> still leaving the closed resource distinction.
That makes total sense. And BC impact is rather minimal given that
closed resources are useless.
> * Normalize error message. IIRC currently our type error messages are
> really weird, in that they use terms like "integer" which are not actually
> valid type hints (or have different meaning). Fixing this doesn't even need
> a proposal, just a PR.
Right. But ensure tests are fixed, that's probably where one has to
spend some time on cleaning it up.
--
Stas Malyshev
smalyshev@gmail.com