Re: [RFC][VOTE] RNG fixes

On Thu, 7 Jul 2016 at 11:39 Leigh <leight@gmail.com> wrote: > As the discussion thread has been quiet for a while, moving this RFC to > voting. > > https://wiki.php.net/rfc/rng_fixes > > https://github.com/php/php-src/pull/1986 Votes are now closed. Results as follows: * 19-5 - Fix mt_rand() implementation * 21-4 - Alias rand() to mt_rand() * 25-0 - Fix RAND_RANGE() * 23-0 - Replace insecure uses of php_rand() with php_random_bytes() * 24-0 - Make array_rand() more efficient There are still a couple of tweaks to the implementation to be done before merging: * Make ranged output the same on 32 and 64 bit platforms where max-min is less than 32 bits * In compatibility mode use the old RAND_RANGE for mt_rand() I intend to make time for these fixes tomorrow.