Re: xmlSetGenericErrorFunc Abuse
| From: | Andi Gutmans | Date: | Fri, 23 Apr 2004 13:57:23 +0000 |
| Subject: | Re: xmlSetGenericErrorFunc Abuse | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-9496@lists.php.net to get a copy of this message | ||
At 02:23 PM 4/22/2004 -0400, Rob Richards wrote:
From: Sterling Hughes I think you are off base in removing them. We need them to hook into PHP's error handling system. I think setting/resetting in RINIT instead of MINIT is a good place to start and see if that fixes the problem. I personally could care less about the threaded case (i hope PHP stops using this TSRM stuff and just recommends FastCGI), although someone here who cares more may have opinions about that. I guess we could add an #ifdef TSRM to the system, and not set the generic error handler - if someone cares enough about the threaddites. Sterling, You're actually correct, go figure ;). I was backwards in the thread calls for libxml. Putting into RINIT/SHUTDOWN works correctly for both the treaded and non threaded systems (the current placement is what would cause problems for threaded servers). Andi, is it okay to commit this change right now?Yes, please do. Thanks, Andi