Re: ReflectionType::__toString() prepending \ to class names
| From: | Levi Morrison | Date: | Sun, 21 Aug 2016 20:20:29 +0000 |
| Subject: | Re: ReflectionType::__toString() prepending \ to class names | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-95355@lists.php.net to get a copy of this message | ||
On Sun, Aug 21, 2016 at 1:52 PM, Marco Pivetta <ocramius@gmail.com> wrote:
> I still want to see code that outweights these commonly used open-source
> tools before you grab that argument again.
>
> As also said by Dan: new features => adaptation required.
>
> Supporting
? in your own home-grown internal code-generator is
> something
> you can do as part of a 7.1 migration path, exactly like we'll have to do
> with the OSS libs.
>
> That said, I'm muting the thread: I'm basically wasting time with this,
> apparently.
>
>
> Marco Pivetta
>
> http://twitter.com/Ocramius
>
> http://ocramius.github.com/
>
> On Sun, Aug 21, 2016 at 9:48 PM, Levi Morrison <levim@php.net> wrote:
>
>> The issue here is around changes that affect old features (__toString),
>>> where the behavior changes depending on whether a parameter is defaulted or
>>> not (also a previously existing feature)
>>>
>>
>> Which has existed for only one release. This is a small BC break and is
>> intended. We previously had nullable types just no way to really encode it
>> as a type. We now do. Breaking code for one single minor version is
>> perfectly acceptable, especially given that there are other codebases that
>> will break if we do not include the question mark.
>>
>>
>
There is a BC break either way. I do not understand why you cannot seem to
fully understand this. If there is a BC break either way why not stick with
intended behavior even if it breaks code for a few tools for a single
version of PHP?