Re: How to properly fix issues in ext/zip?
| From: | Christoph M. Becker | Date: | Mon, 05 Sep 2016 17:28:20 +0000 |
| Subject: | Re: How to properly fix issues in ext/zip? | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-95662@lists.php.net to get a copy of this message | ||
On 05.09.2016 at 18:40, Remi Collet wrote:
> Le 05/09/2016 à 18:23, Christoph M. Becker a écrit :
>
>> I've stumbled upon <https://bugs.php.net/70752>
>> and could fix it, but
>> I'm not sure whether the fix should be applied to php-src/ext/zip or
>> rather against PECL/zip (i.e.
>> <https://github.com/pierrejoye/php_zip>).
>>
>> So, which repo is the "master" – ext/zip or PECL/zip?
>
> Both should be updated.
>
> At least php-src.
>
> I usually take care to keep pecl/zip synced, but of course if you can
> also do it, you are very welcome.
Okay, so I take it that updates should go to php-src/ext/zip first.
That suits me fine. If it is helpful for you, I can file respective
issues for any updates I'll do to php-src/ext/zip.
> pecl/zip allow to run latest version (using latest libzip) with older
> PHP version.
Yes, I know, and I think it's good this way. :-)
--
Christoph M. Becker