Re: RFC - Immutable classes
| From: | Silvio Marijić | Date: | Fri, 09 Sep 2016 21:26:51 +0000 |
| Subject: | Re: RFC - Immutable classes | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-95879@lists.php.net to get a copy of this message | ||
@Fleshgrinder,
Well since implementation is still underway I think the best ways would be
to wait untill we finish implementation, and then we all can do the review
to make sure everything is in place.
2016-09-09 23:16 GMT+02:00 Fleshgrinder <php@fleshgrinder.com>:
> On 9/9/2016 10:02 PM, Silvio Marijić wrote:
> > It will be patched before this RFC goes into official discussion.
> >
>
> That explains why all the rewritten tests I provided for Reflection fail:
>
> https://github.com/brzuchal/php-src/pull/1
>
> Should I create this PR against another repository? I created it against
> the one that was last posted for review but no clue which would be right
> one to contribute here?!?
>
> --
> Richard "Fleshgrinder" Fussenegger
>
>
--
Silvio Marijić
Software Engineer
2e Systems