Re: HashDoS
| From: | Yasuo Ohgaki | Date: | Sat, 17 Sep 2016 22:35:50 +0000 |
| Subject: | Re: HashDoS | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-96025@lists.php.net to get a copy of this message | ||
Hi all,
On Sat, Sep 17, 2016 at 5:13 PM, Stanislav Malyshev <smalyshev@gmail.com> wrote:
>> Significant degradation?
>>
>> SipHash 1-3 is almost as fast as HashDoS-vulnerable hash
>> functions: https://github.com/funny-falcon/funny_hash
>
> I see on this link comparison to Murmur3 - but that's not the function
> we are using. Is there a comparison to PHP one?
Unfortunately, SipHash was a lot slower. BJB hash is simple and super
fast, even google's CityHash was a lot slower when I tested. (Sorry I
don't keep the number)
I think we are better to limit max collisions.
I'm +1 for Nikita's proposal does this.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net