Re: Fix ReflectionType::__toString() BC break
| From: | Niklas Keller | Date: | Tue, 04 Oct 2016 07:23:35 +0000 |
| Subject: | Re: Fix ReflectionType::__toString() BC break | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-96209@lists.php.net to get a copy of this message | ||
Marco Pivetta <ocramius@gmail.com> schrieb am Sa., 1. Okt. 2016, 15:27:
> At the moment, the fact that it raises a fatal due to __toString()
> limitations is a problem. Probably good to delay or RFC it.
>
You mean if errors are converted to exceptions? If you do that, deprecation
warnings should usually not be converted.
On 1 Oct 2016 09:17, "Niklas Keller" <me@kelunik.com> wrote:
>
> Marco Pivetta <ocramius@gmail.com> schrieb am Sa., 1. Okt. 2016, 01:20:
>
> On Mon, Sep 26, 2016 at 7:44 AM, Pierre Joye <pierre.php@gmail.com> wrote:
>
> > Also follow the discussion here
> >
> >
> > https://github.com/php/php-src/pull/2137#issuecomment-249353056
> >
>
> Follow-up on this, since RC3 was tagged with
> https://github.com/php/php-src/pull/2137 merged into it.
>
> BC Issue seems to be resolved from my perspective, and some sort of
> soft-deprecation was introduced (deprecated, but no deprecation notice
> triggered).
>
>
> I think we should deprecate it with a notice, or should we wait until 7.2
> with that?
>
> Nicolas, can you confirm if this works on your side?
>
> Greets,
>
> Marco Pivetta
>
> http://twitter.com/Ocramius
>
> http://ocramius.github.com/
>
>