RE: [PHP-DEV] Constants for better double edge case handling
| From: | Anatol Belski | Date: | Tue, 18 Oct 2016 19:15:35 +0000 |
| Subject: | RE: [PHP-DEV] Constants for better double edge case handling | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-96442@lists.php.net to get a copy of this message | ||
Hi Kalle,
> -----Original Message-----
> From: kalle.php@gmail.com [mailto:kalle.php@gmail.com] On Behalf Of Kalle
> Sommer Nielsen
> Sent: Tuesday, October 18, 2016 9:05 PM
> To: Anatol Belski <anatol.php@belski.net>
> Cc: PHP Internals <internals@lists.php.net>; Davey Shafik <davey@php.net>; Joe
> Watkins <krakjoe@php.net>
> Subject: Re: [PHP-DEV] Constants for better double edge case handling
>
> Hi Anatol
>
> 2016-10-18 20:46 GMT+02:00 Anatol Belski <anatol.php@belski.net>:
> > Hi,
> >
> > I would like to suggest adding the following constants
> >
> > REGISTER_MAIN_LONG_CONSTANT("PHP_DBL_DIG", DBL_DIG,
> > CONST_PERSISTENT | CONST_CS);
> > REGISTER_MAIN_DOUBLE_CONSTANT("PHP_DBL_MAX", DBL_MAX,
> > CONST_PERSISTENT | CONST_CS);
> > REGISTER_MAIN_DOUBLE_CONSTANT("PHP_DBL_MIN", DBL_MIN,
> > CONST_PERSISTENT | CONST_CS);
> > REGISTER_MAIN_DOUBLE_CONSTANT("PHP_DBL_EPSILON", DBL_EPSILON,
> > CONST_PERSISTENT | CONST_CS);
> >
>
> I like this idea but I do think that we should name them PHP_DOUBLE_* or
> PHP_FLOAT_* (preferably the first).
>
Ah, indeed. PHP_FLOAT_* is what is consistent, probably.
Thanks
Anatol