Re: Re: Fixing insane session_start() behaviors
| From: | Yasuo Ohgaki | Date: | Wed, 19 Oct 2016 12:07:43 +0000 |
| Subject: | Re: Re: Fixing insane session_start() behaviors | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-96475@lists.php.net to get a copy of this message | ||
Hi Davey,
On Wed, Oct 19, 2016 at 6:06 PM, Davey Shafik <davey@php.net> wrote:
> Yasuo, assuming "partial fix" doesn't mean "broken fix" but instead
> "it
> doesn't do everything I planned" then I do not want this in 7.1. As others
> have pointed out, it's not a small change and sessions are a fundamental
> part of PHP — we are simply too far into the release cycle to include this.
>
> Please target 7.2/master.
OK. I'll merge this to master.
Partial fix is done so that it does not break internal API signatures.
It's fixed as plain bug fix. PHP 7.1's session_start() sets a little
better session status and 'FALSE' than older PHP, but it's far from
correct/reliable. I'll update UPGRADING comment.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net