Re: DateTime microseconds discussion
| From: | Davey Shafik | Date: | Tue, 08 Nov 2016 18:08:06 +0000 |
| Subject: | Re: DateTime microseconds discussion | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-96775@lists.php.net to get a copy of this message | ||
On Tue, Nov 8, 2016 at 6:28 AM, Alice Wonder <alice@librelamp.com> wrote:
> On 11/08/2016 04:16 AM, Arjen Schol wrote:
>
>> Hi Dan,
>>
>> I think you make some bad assumptions here. The examples provided by
>> Sjon are scripts submitted to 3v4l.org They may have bad assumptions,
>> but are real life examples of DateTime usage. And they will break.
>>
>
> They are already broken. That's the point.
>
> Rarely will the current breakage trigger but it will trigger.
>
> Personally I prefer it when bad code obviously triggers, it can be very
> difficult (read expensive) to track bugs in code that only rarely and
> randomly trigger.
I have discussed this with Joe, and we are OK with the warning BC break;
everything else is not considered a BC break.
We should definitely document some best practices around relative dates,
e.g. using midnight, or explicitly setting the time.
Thanks,
- Davey