Re: [RFC][VOTE] User defined session serializer
| From: | Bob Weinand | Date: | Tue, 06 Dec 2016 13:36:56 +0000 |
| Subject: | Re: [RFC][VOTE] User defined session serializer | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-97307@lists.php.net to get a copy of this message | ||
Hey,
> Am 06.12.2016 um 08:06 schrieb Yasuo Ohgaki <yohgaki@ohgaki.net>:
>
> Hi all,
>
> *snip*
>
> * Why it does not use exception for error?
>
> Session module uses "errors", not "exceptions" basically. Session save
> handler uses "errors" also. We should avoid inconsistency in a module.
> Exception adoption will be addressed and exceptions will be used
> consistent manner by other RFC.
This is not session module specific, your interface is specifying a return type. Thus this should be
enforced on the interface implementation level. (I.e. it will be impossible for an user to define a
function not having a return type of string/array)
Also, if a wrong argument is passed to a function, it should throw a type error. Perhaps old modules
from pre-PHP 5 do emit warnings or recoverables, but we then shall transition from that to
TypeError, and definitely use TypeError in new functionality.
Bob