Re: [RFC][VOTE] array_change_keys

Hi Colin, Voting NO for the following reasons: * Can be a userland function/library, unless there are huge performance benefits that justify it being in core * Doesn't work with iterable * New warnings. No, please, we want Throwable: warnings are terrible * Semantics for merging duplicate keys should be part of the function name, or a parameter (the former being better, having a strict version that fails, and a merging version that overwrites) * I totally forgot that I benchmarked this before :-\ https://github.com/Ocramius/array_change_keys-benchmark Marco Pivetta http://twitter.com/Ocramius http://ocramius.github.com/ On Sun, Jan 8, 2017 at 3:21 PM, Colin O'Dell <colinodell@gmail.com> wrote: > Greetings all, > > It's been a while since we introduced the array_change_keys RFC > <https://wiki.php.net/rfc/array_change_keys>. During the > discussion > period > there was a healthy mix of interest and critique. It seems all the major > discussion points were covered, so I'd like to put this RFC to a vote to > determine its fate. > > Therefore, voting is now open on the array_change_keys RFC: > https://wiki.php.net/rfc/array_change_keys Voting will close > 2017-01-23 > at > 23:59:59 UTC. > > Mailing list discussion thread: > > https://marc.info/?l=php-internals&m=146452769326964&w=2 > > Reddit discussion thread: > > https://www.reddit.com/r/PHP/comments/4ll1hg/rfc_array_change_keys/ > > The implementation is also on 3v4l.org should you wish to test it out. > > Regards, > > Colin O'Dell >