Re: [RFC][Discussion] ServerRequest and ServerResponse objects

Hi Arvids, > On Jan 10, 2017, at 17:22, Arvids Godjuks <arvids.godjuks@gmail.com> wrote: > > I would also add the support, bug and feature issues that will definitely crop up with such an > interface. If there is a major bug, flaw or security issue, getting it fixed is going to be a > problem, because as we know, the adoption of PHP is nowhere near instantaneous and it can be years > before you get the actual fix into the servers your project/projects are running on, and you > can't do anything about this. (/me nods) That particular problem is not specific to this RFC, though. It's true for anything that gets into PHP. > There are also questions - a 1GB upload comes in, will interface implement streams or some > other way of handling that? Or there is a 200MB gallery upload of images, with how most hosts set up > their memory limits, I would imagine this would just run out of memory. And all that stuff. Interesting -- what happens *now* without the ServerRequest RFC? If a 1GB upload comes in (or a 200MB gallery upload of images), then it gets dealt with under the RFC in exactly the same with PHP deals with it right now. That is: probably by attempting to store the uploads on disk, then exposing the file information via $_FILES. > It's a way bigger job than I think the proposing person thinks, and it needs major support > from the project maintainers, because I'm 146% sure one person will not be able to do it all > and maintain it for next 10 years before it becomes integral part of the core... It might well be a way bigger job than John & I think. However, I do have to point out that the vast majority of the functionality is pretty straightforward, and not terribly complex. It's certainly not at the PDO, XML, Filter, etc. level of intricacy. > This is something that needs to be tested and runned as a module for quite some time before it > is stable enough to be in the core anyway - just see what happened to PDO - as far as I know, no > one really wants to touch it, it's a mess. I can't speak to PDO, but I can say that APIs very similar to the one proposed in the RFC have been around for a long time, implemented by many different developers in many different systems. This RFC represents a summation and condensation of those behaviors. -- Paul M. Jones pmjones88@gmail.com http://paul-m-jones.com Modernizing Legacy Applications in PHP https://leanpub.com/mlaphp Solving the N+1 Problem in PHP https://leanpub.com/sn1php