Re: Re: [RFC] Extended String Types For PDO

On 26/2/17 9:07 am, Marco Pivetta wrote:

Hi Adam On Fri, Feb 24, 2017 at 2:28 PM, Adam Baratz <adam.baratz@gmail.com> wrote:

Based on some pain points with my team and things I've heard from others, I created an RFC to handle "national" character sets for emulated

prepared

statements: https://wiki.php.net/rfc/extended-string-types-for-pdo I had previously suggested this as a driver-specific change, but believe it's worthwhile to make it generic since it affects multiple drivers: https://externals.io/thread/400#email-12542 Please let me know what you think. Thanks, Adam

Any thoughts on this one?

DBAL maintainer here: before we introduce even more complexity into the PDO stuff (which is already a maze), could a set of test cases be written, so that stuff that is currently impossible to do without this RFC is clearer/demonstrated? I'm asking because we didn't get any bug reports about extended string types for Doctrine DBAL, and adding new types just to workaround the limitations of the usual suspects (remember that PDO for SQLServer is experimental, if not totally unusable) is shotgun surgery, and just more complexity to handle. Greets, Marco Pivetta http://twitter.com/Ocramius http://ocramius.github.com/ I agree the spec could definitely do with some samples and detail.

At a start, what about defining 'N-prefix' so the reader doesn't have to trawl through references?! And clarify whether the PR is for the generic solution or the earlier problem. More importantly, what about allowing arbitrary quote delimiters? https://livesql.oracle.com/apex/livesql/file/content_CIREYU9EA54EOKQ7LAMZKRF6P.html Chris -- http://twitter.com/ghrd