Re: [RFC] [VOTE] Improve hash_hkdf() parameter

On Sat, Mar 25, 2017 at 3:25 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote: > Hi all, > > Since hash_hkdf() is in PHP 7.1.2, I start vote from today. > > Current hash_hkdf() function signature does not make sense. > > - hash_hkdf() is simple hash_hmac() extension, yet it has totally > different signature. > - Return value is binary unlike other hash functions. > - The signature is insecure. > > https://wiki.php.net/rfc/improve_hash_hkdf_parameter > > Current signature is overly optimized very limited crypto operation > and cannot be optimal by above reasons. > > Fortunately, almost all users are not using current hash_hkdf(). > It's only from 7.1.2 to 7.1.4 now. We should avoid yet another > new inconsistent and insecure function. It would be better to be > fixed ASAP, IMHO. > > Vote start: 2017-03-25 > Vote end: 2017-04-06 UTC 23:59:59 > Voting against this because it introduces a BC break on a stable branch in a point release. Of course I also disagree with the proposed change itself, but this has already been extensively discussed in previous threads, and I believe the BC break is sufficient grounds for rejection on its own. I cannot, however, entirely refrain from pointing out the irony of making all parameters but $length required, while $length is actually the one parameter that any reasonable use of this function must specify: otherwise you would depend on the digest size of the hash function magically coinciding with the key length of your cipher (for example). Nikita