Re: [RFC][VOTE] Allow abstract function override

Le mar. 28 mars 2017 à 06:51, Wes <netmo.php@gmail.com> a écrit : > Hello PHPeeps, > > There hasn't been much discussion around the proposed feature, and I've > interpreted it as a good sign :P It is not a super important change but it > has some advantages, it's consistent with the recent improvements to type > variance and also with future ones. Also, it's hopefully not too hard to > implement. > > https://wiki.php.net/rfc/allow-abstract-function-override > > I've decided to start the vote. It will end two weeks from this message, on > 10th April 2017. > > Thanks in advance for participating. > > Wes > Hello, Voted "no" because the RFC starts with: " PHP 7 introduced type declarations for return and improved ones for parameters. They currently support a very limited kind of variance (only to no-type): <?php class A { function bar(stdClass $x){} } class B extends A { function bar($x): stdClass{} } " Which looks false in both PHP 7.0 and PHP 7.1. Sorry if I missed something in a past discussions, but it looks wrong to me to implement anything based on a false assertion. I would be happy to change my vote if you can fix the RFC and/or enlight me.. Cheers, Patrick