Re: [RFC] PDO Float Type
| From: | Adam Baratz | Date: | Wed, 12 Apr 2017 15:21:58 +0000 |
| Subject: | Re: [RFC] PDO Float Type | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-98776@lists.php.net to get a copy of this message | ||
>
> > I'd suggest adding a warning to the manual instead.
>
> I think that's a requirement in any case.
I'd be most comfortable with this approach. I'd worry about adding a
PDO::PARAM_NUMERIC type without investigating how it needs to function for
each DB, which feels like scope creep. If it starts off as an alias for
PDO::PARAM_STR, there could be issues updating it to work correctly,
especially if the right design involves modeling the precision somewhere. I
added a "Future Scope" section covering this.
Let me know if there are major problems with this or other points to cover.
Otherwise, I'll aim to open voting on Monday.
Thanks,
Adam