Re: On malformed transport strings
| From: | Sara Golemon | Date: | Wed, 26 Apr 2017 22:10:16 +0000 |
| Subject: | Re: On malformed transport strings | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-98888@lists.php.net to get a copy of this message | ||
On Wed, Apr 26, 2017 at 1:19 PM, Anatol Belski <ab@php.net> wrote:
> What I'd basically avoid is making changes in stress,
> as there might be other beyond places and we shouldn't
> risk to introduce more breach than there already is.
> Instead, that requires a cold head and a lot of QA 😉
>
Which is precisely why I'm advocating reverting the whole lot. I've
just sat down to try to at least address the mysqli_connect part and
it's hairy. Basically we've built in precisely the kind of bad
assumption that I was initially grousing about frameworks having done.
I don't mean to ignore the security issue presented by 74216, I just
recognize that my initial fix was made hastily and we should allocate
more time to fix it properly (with all that lovely QA and testing).
-Sara