Re: [RFC] deprecate PDO::PARAM_NULL
| From: | Matteo Beccati | Date: | Thu, 18 May 2017 05:21:13 +0000 |
| Subject: | Re: [RFC] deprecate PDO::PARAM_NULL | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-99091@lists.php.net to get a copy of this message | ||
Hi Adam,
On 15/05/2017 13:49, Adam Baratz wrote:
> I've heard a few people here mention that this type isn't useful. It looks
> like it wouldn't be harmful to remove. The RFC mainly outlines the impact
> and proposes a schedule for doing so.
>
> https://wiki.php.net/rfc/deprecate_pdo_null
>
> Please let me know your thoughts.
Please elaborate:
"A handful of people on the internals mail list have asked for it to be
removed" - where and when?
"Supporting it adds some weight to PDO" what kind of weight? How many
lines / microseconds are we going to save?
I would agree that NULL is not a type and the constant shouldn't have
been there in the first place, but I think it could be a bit too late now.
The proposal itself is rather evil: it would break lots of code (a quick
github search shows 95k+ results) for basically no gain. Or maybe I just
didn't get it.
Cheers
--
Matteo Beccati
Development & Consulting - http://www.beccati.com/