Re: Implement formal process for run-tests.php refactor

On Mon, May 29, 2017 at 8:20 PM, Stanislav Malyshev <smalyshev@gmail.com> wrote: >> Is that worth a shot, do you think? > > Definitely. There's no reason also why it shouldn't work so failing > tests in such scenario probably should be treated as bugs. > > A lot of tests also inherently parallel-safe - probably majority of > them, though wouldn't claim I am 100% sure - so maybe marking them as > such is also not bad. > HHVM imported PHP's core test suite and its test running *is* parallelized. We ran into a number of tests which aren't parallel friendly (shared, hard-coded port number and/or tempfile path) and I upstreamed fixed for all the tests we had issue with, so the state of PHP's tests *now* should be pretty good. (Of the extensions HHVM actually has in common, anyway). There are a handful of cases where some tests simply expect to be run in order, and we flagged these using a marker file: testname.php.serial (See: https://gist.github.com/sgolemon/429e4deb413eb539d653460ae062c228 ) -Sara