Error of codes on page https://wiki.php.net/phpng-upgrading
| From: | ideal | Date: | Wed, 21 Jun 2017 02:33:55 +0000 |
| Subject: | Error of codes on page https://wiki.php.net/phpng-upgrading | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-99582@lists.php.net to get a copy of this message | ||
Hi,
The codes that show usage of smart_string:
- smart_str str = {0};
- smart_str_appendl(str, " ", sizeof(" ") - 1);
- smart_str_0(str);
- RETURN_STRINGL(implstr.c, implstr.len, 0);
+ smart_string str = {0};
+ smart_string_appendl(str, " ", sizeof(" ") - 1);
+ smart_string_0(str);
+ RETVAL_STRINGL(str.c, str.len);
+ smart_string_free(&str);
Maybe actually should be:
- smart_str str = {0};
- smart_str_appendl(str, " ", sizeof(" ") - 1);
- smart_str_0(str);
- RETURN_STRINGL(implstr.c, implstr.len, 0);
+ smart_string str = {0};
+ smart_string_appendl(&str, " ", sizeof(" ") - 1);
+ smart_string_0(&str);
+ RETVAL_STRINGL(str.c, str.len);
+ smart_string_free(&str);
Thanks.