Re: phpweb /include layout.inc
| From: | Rasmus Lerdorf | Date: | Sun, 19 May 2002 13:55:47 +0000 |
| Subject: | Re: phpweb /include layout.inc | ||
| References: | 1 | Groups: | php.mirrors |
| Request: | Send a blank email to php-mirrors+get-10325@lists.php.net to get a copy of this message | ||
Try this link:
http://us2.php.net/do_download.php?download_file=php-4.2.1-Win32.zip
Then compare to:
http://us2.php.net/distributions/php-4.2.1-Win32.zip
Which one works better?
I really didn't dig into why do_download.php was timing out. All I know
is that everyone complained that they couldn't download anything so the
quick and obvious fix was to get rid of do_download for now and work out
later why it is broken.
-Rasmus
On Sun, 19 May 2002, Gabor Hojtsy wrote:
> > rasmus Sun May 19 01:31:28 2002 EDT
> >
> > Modified files:
> > /phpweb/include layout.inc
> > Log:
> > Downloads are broken - temporary fix until the master server is back
> >
> >
> > Index: phpweb/include/layout.inc
> > diff -u phpweb/include/layout.inc:1.85 phpweb/include/layout.inc:1.86
> > --- phpweb/include/layout.inc:1.85 Tue May 14 17:21:32 2002
> > +++ phpweb/include/layout.inc Sun May 19 01:31:27 2002
> > @@ -1,5 +1,5 @@
> > <?php
> > -/* $Id: layout.inc,v 1.85 2002/05/14 21:21:32 goba Exp $ */
> > +/* $Id: layout.inc,v 1.86 2002/05/19 05:31:27 rasmus Exp $ */
> >
> > # spacer()
> > # print a IMG tag for a sized spacer GIF
> > @@ -163,7 +163,8 @@
> > $size = @filesize($local_file);
> > //echo("<!-- file=$file localfile=$local_file size-$size -->\n");
> >
> > - print_link("/do_download.php?download_file=$file", $title);
> > +# print_link("/do_download.php?download_file=$file", $title);
> > + print_link("/distributions/$file", $title);
>
> I don't understand what is this have to do with the main server.
> This printed out a link on the same machine, which tried to reach
> the master server with a shutdown function, so a downtime of that
> main server does not affect any downloads, just they won't be logged...
> At least I cannot see any point in this modification...
>
> Goba
>
>