Re: Ip-to-country
| From: | Gabor Hojtsy | Date: | Tue, 06 May 2003 11:32:36 +0000 |
| Subject: | Re: Ip-to-country | ||
| References: | 1 2 | Groups: | php.mirrors |
| Request: | Send a blank email to php-mirrors+get-17361@lists.php.net to get a copy of this message | ||
> > Okay now I'm really going to bed. Works for me using commandline CURL
> > it's not tuning me that it can't find my country:
> >
> > <blockquote>
> > We detected that you are from <b>South Africa</b></blockquote>
> >
> > Rasmus if you remove the cookie you should find that the detection works
> > better. Prob putting a lower ttl on the cookie would not be a bad idea?
>
> I'd either make it a session cookie or put the ip into the value of the
> cookie.
I have also considered adding the IP into the cookie, and I have added this
as a comment into the .inc file too ;) But I thought it will make more
pressure on the selection code for those with dynamic IP, but as the
detection does not take any significant time [and you also suggested putting
it into a session cookie], I think we can just put the IP into the cookie
[and then we can increase it's lifetime too].
I'll look into this when I get to my home machine,
Goba