Re: phpweb / quickref.php search.php searchbar.php sidebars.php sitemap.php sites.php submit-event.php support.php thanks.php tips.php unsub.php
urlhowto.php
| From: | Rasmus Lerdorf | Date: | Fri, 16 May 2003 14:07:22 +0000 |
| Subject: | Re: phpweb / quickref.php search.php searchbar.php sidebars.php sitemap.php sites.php submit-event.php support.php thanks.php tips.php unsub.php urlhowto.php |
||
| References: | 1 | Groups: | php.mirrors |
| Request: | Send a blank email to php-mirrors+get-17742@lists.php.net to get a copy of this message | ||
On Fri, 16 May 2003, Gabor Hojtsy wrote:
> First of all you have some ID tags wrongly added.
> Second I have seen that Ramsus changed most of the
> include_once and require and require_once calls to
> "include"s - but not in all of the calls he modified.
> I don't really know if using the version without "once"
> is intentional and treated to be a performance increase.
> But looking though your changes we have several other
> include type keywords left. Wouldn't it be better to finally
> settle at one and use it sitewide???
*_once involves an extra hash lookup. We should be able to keep our
architecture such that we don't have to worry about multiple inclusion of
our include files, and if someone makes a mistake and includes a file that
has already been included, then I'd rather see the error or page
corruption so we will know to fix it. I also think it is a bad habit to
always use include_once everywhere.
-Rasmus