RE: phpweb /include layout.inc

It should be a given that you test your changes before committing. I know sometimes we all get a bit lazy and figure short little fixes can't mess anything up. I am guilty of that as well. But we really should try to test it offline. If you aren't capable of setting up a php.net mirror, you really shouldn't be messing with this code. -Rasmus On Wed, 21 May 2003, Philip Olson wrote: > On Wed, 21 May 2003, James Moore wrote: > > Hi all, > > > > The amount of errors that are happening at the moment with commits isn't > > really acceptable can I suggest one of two things: > > > > 1) People TEST before they commit by setting up a local mirror. > > > > 2) Set up staging.php.net which updates from CVS every 30 secs/1 min or > > couple it to a shell script in the cvs commit process which updates it > > automatically so people can catch errors on a non production server and > > slow PHP.net cvs updates to every hour or upon an email being received > > that validates the commit (IE a reply to this email would validate the > > commit as tested and allow it to go live). > > > > This number of errors would not be acceptable on a corporate site and we > > should not accept them on php.net since it doesn't look good and its > > careless and unnecessary. If you cant test yourself send a patch and get > > someone who can test to do so before the commit. These errors are > > avoidable and its silly to keep letting them happen. > > How about first doing a lint check on files before phpweb > accepts them from CVS? If php -l foo.php passes then the file > will be accepted else email the webmaster. Something like > that. Of course this would be pretty parental... :) > > Regards, > Philip > >