Re: cvs: php-bugs-web / report.php
| From: | Andrew Lindeman | Date: | Tue, 01 Jul 2003 13:34:29 +0000 |
| Subject: | Re: cvs: php-bugs-web / report.php | ||
| References: | 1 2 | Groups: | php.mirrors |
| Request: | Send a blank email to php-mirrors+get-19082@lists.php.net to get a copy of this message | ||
The argument was that people would use "Irrelevant" for other bugs that
need a version, if they didn't know their version or were too lazy to
find it out. I'll do whatever, but there are worse things already on
php.net than this few lines of JS.
--Andrew
On Tue, 2003-07-01 at 08:27, Jani Taskinen wrote:
> Please revert. Just add a new version 'Irrelevant'
> in the version select box..no need for this JS crap, IMO.
>
> --Jani
>
>
> On Tue, 1 Jul 2003, Andrew Lindeman wrote:
>
> >alindeman Tue Jul 1 09:10:40 2003 EDT
> >
> > Modified files:
> > /php-bugs-web report.php
> > Log:
> > fix bug #23529. Add some "js tricks" to add an "Irrelevant"
> > version option when submitting php.net bugs only.
> >
> >
> >Index: php-bugs-web/report.php
> >diff -u php-bugs-web/report.php:1.37 php-bugs-web/report.php:1.38
> >--- php-bugs-web/report.php:1.37 Mon Jun 30 08:30:41 2003
> >+++ php-bugs-web/report.php Tue Jul 1 09:10:40 2003
> >@@ -227,6 +227,24 @@
> >
> > if ($errors) display_errors($errors);
> > ?>
> >+<script language="javascript" type="text/javascript">
> >+var irrelevantOn = false;
> >+
> >+function handleVersionChange (obj) {
> >+ if (obj.value == "Website problem") {
> >+ irrelevantOn = true;
> >+
> >+ document.forms[1].elements[2].options[document.forms[1].elements[2].options.length] =
> >new Option("Irrelevant", "Irrelevant", true, true);
> >+ } else {
> >+ if (irrelevantOn) {
> >+ document.forms[1].elements[2].options[document.forms[1].elements[2].options.length - 1]
> >= null;
> >+ document.forms[1].elements[2].options[0].selected = true;
> >+ irrelevantOn = false;
> >+ }
> >+ }
> >+}
> >+</script>
> >+
> > <form method="post" action="<?php echo $PHP_SELF;?>">
> > <input type="hidden" name="in[did_luser_search]"
> > value="<?php echo $in['did_luser_search'] ? 1 : 0; ?>" />
> > <table>
> >@@ -243,7 +261,7 @@
> > </tr><tr>
> > <th align="right">Type of bug:</th>
> > <td colspan="2">
> >- <select name="in[bug_type]"><?php
> >show_types($in['bug_type'],0);?></select>
> >+ <select name="in[bug_type]" onChange="javascript:
> >handleVersionChange(this)"><?php
> >show_types($in['bug_type'],0);?></select>
> > </td>
> > </tr><tr>
> > <th align="right">Operating system:</th>
> >
> >
--
Andrew Lindeman <alindeman@php.net>